Set logging level to 'info' for message about init system detection #37252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR stops Salt complaining about it was unable to detect the init system on Linux each time when Grain data is going to be refreshed.
In case if you're using Salt to build or provision containers (where PID 1 could be virtually anything, even Salt itself!) or you've moved to other not so popular init replacements such as
monitorrunit, then this message becomes very annoying:Since Salt, called interactively, outputs errors to
stderrby default, and it is generally a bad practice to disable error logging at all, I think it would be better to put the message above to the 'info' loglevel.Tests written?
No