Removed overloading of list()

[yhekma]

What does this PR do?

Fix the consul backend for minion cache

What issues does this PR fix or reference?

#38677

Previous Behavior

When using the consul cache backend, you could run into:
SaltCacheError: There was an error getting the key "set([u'host1', u'host2', u'host3', u'host4'])": unsupported operand type(s) for +: 'set' and 'str' because the function getting the data was called list and also attempted to return a casted list (which turned out to be the function itself)

New Behavior

It works(tm)

Please review Salt's Contributing Guide for best practices.

[DmitryKuzmenko]

@yhekma good catch! Thank you!

[techhat]

__func_alias__ is the correct way to fix this. I have corrected it in #38660, while rebasing for this PR.

[yhekma]

Is it? The reason I did it this way (the renaming of the function) was because I didn't even thing to use __function_alias. Explicit is better than implicit and all that..... (PEP20)

[techhat]

That's why we added __func_alias__. There's examples all over the code if you'd like to check them out.

[yhekma]

Yeah, I saw, I guess I just don't like using it because it's cleaner to just use another name imo:)
Regardless, if that's the way it is done in the code, that's the way this fix should be done. Thanks for the fix!

[techhat]

PEP20 is nice and all, but remember that code isn't just for the programmer; it's for the users too. And list is easier to remember and faster to type than getlist. Regardless, I left getlist in there for you too.

[yhekma]

For things like id I tend to agree, it's just that I actually use list() once in a while, hence my reluctance. It's easy to remember, but now I also need to remember that in this particular context it means something different than it normally does.
I have to say I didn't check the rest of the code before submitting this PR (which I should have done to ensure consistency) and would have used __func_alias__ otherwise I think.