Second attempt to fix prepending of root_dir to paths #38804
Conversation
|
@cachedout there are several integration tests failing, but I'm not familiar with the code and don't understand the failures. Can you have a look? |
|
Go Go Jenkins! |
1 similar comment
|
Go Go Jenkins! |
|
@cachedout Did you have time to look into the failed test? I can't reproduce the failure so my hands are tied |
|
@cro This is the pull request to fix the root_dir override. It works in my environment, but it fails an integration test here |
|
@alexbleotu I will take a look. |
|
@alexbleotu I sent a PR with a couple cleanups to your fork. If you agree & merge, then re-push here we'll get the tests to run again. It looks like the test failures are unrelated but one set of them already got cleaned up by Jenkins so I could not look at it. |
Remove extra if statements (rstrip will check for the presence anyway).
|
@cro done, thanks for the patch |
When running testsuite, salt.syspaths.ROOT_DIR is often empty.
|
No pylint violations in the jenkins job? |
What does this PR do?
Second attempt to fix prepending of root_dir to paths
Fixes: #38663
Previous Behavior
Prepended the root_dir override to the default one
New Behavior
Prepend the root_dir override only
Tests written?
No
Please review Salt's Contributing Guide for best practices.