Keep the only one record per module-function in depends decorator. #38951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, maybe it's better to rebase it to 2016.3 branch? It's also affected. |
|
@DmitryKuzmenko Yes, that is what we will want. I tried to change the base here but it did not merge cleanly at all. Could you please close this and open another PR against 2016.3? Thanks. |
|
@cachedout will do. |
DmitryKuzmenko
force-pushed
the
bugs/37938_fix_depends_decorator_memleak
branch
from
8749f9a
to
0b18f34
Compare
|
@cachedout I've rebased the branch and changed the base here so there's no need to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As I see the initial design of the
dependsdecorator usedsetto keep the unique seet of decorated functions determined by the module, function and it's alternative implementation.After functions become loaded with lazyloader the same function loaded twice become another object.
Also the
modulewas replaced byframethat is also another object each time.What we got as a result:
dependsdecorator leaks on eachlazyloaderinstantiation.What issues does this PR fix or reference?
Fixes: #37938, #33890
Previous Behavior
dependsuses asetof(frame, function, alternative_function)to reference the decorated functions.New Behavior
Use
dictwhere the key is(module_name, function_name)to keep the only unique functions.Tests written?
No