Run test_valid_docs in batches #39091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terminalmage
force-pushed
the
update-test-valid-docs
branch
from
0a07e9b
to
0fd5d66
Compare
terminalmage
added
the
pending-changes
This test fails often due to being trimmed, thanks to salt.utils.dicttrim trimming values > max_event_size. This commit changes this test so that it runs sys.doc twice, ensuring that the return from sys.doc (for now) is not trimmed.
This keeps trimmed output from failing the test. We are still testing with a specific module lower down in the test, so this doesn't reduce our test coverage.
terminalmage
force-pushed
the
update-test-valid-docs
branch
from
7657508
to
d76f038
Compare
terminalmage
added
Tests-Passed
and removed
pending-changes
|
Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails often due to being trimmed, thanks to
salt.utils.dicttrim trimming values > max_event_size.
This commit changes this test so that it runs sys.doc twice, ensuring
that the return from sys.doc (for now) is not trimmed.