New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The lint fix broke some tests: use pylint disable instead #39226

Closed

rallytime wants to merge 1 commit into saltstack:2016.3 from rallytime:win-ip-lint

Contributor

rallytime commented Feb 7, 2017 •

edited

The change in #39202, which was a follow up to #38793, broke the following tests:

unit.modules.win_ip_test.WinShadowTestCase.test_get_interface
unit.modules.win_ip_test.WinShadowTestCase.test_get_all_interfaces


          The lint fix broke some tests: use pylint disable instead

b7e5395

Contributor Author

rallytime commented Feb 7, 2017

This is not the right way to fix this. I made a mistake.

I thought these were passing before my original pylint fix, but that is not the case. The tests were broken originally in #38793.

rallytime closed this

rallytime deleted the win-ip-lint branch

February 7, 2017 18:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment