New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py3 Fixes #39320
Py3 Fixes #39320
Conversation
9a0851a
to
3af2255
Compare
@s0undt3ch great stuff. I am running python3 on prod. for a while and I monkey-patched some of these issues you are fixing right now.
Btw...the worst non-fixed yet py3 bugs(I need to make a list) I remember are:
|
b89c125
to
ba134c8
Compare
Go Go Jenkins! |
Using `six.b()` in this particular case is all we need to do.
ba134c8
to
8e5a31f
Compare
@s0undt3ch I fully tested your PR and now I am running it on production with no problems with python3 |
Production? You are brave!!! |
😄 |
Plus, this also avoids handling Py2 and Py3 differently.
@s0undt3ch Just one lint error to be looked at, please: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/8525/violations/file/salt/netapi/__init__.py/ |
Fixed. |
What does this PR do?
Py3 fixes for the file state module (and some more minor stuff)