Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-walk the roots fileserver in symlink_list() #39337

Merged
merged 1 commit into from Feb 13, 2017

Conversation

terminalmage
Copy link
Contributor

This prevents some unnecessary extra work when getting a list of
symlinks.

This prevents some unnecessary extra work when getting a list of
symlinks.
@ninja-
Copy link
Contributor

ninja- commented Feb 12, 2017

@terminalmage would that be an improvement also for people without symbolic links in their salt trees?

@terminalmage
Copy link
Contributor Author

@ninja- I don't think there would be a performance gain for fileservers without symbolic links. The issue as initially reported by @UtahDave involved a fileserver with a number of symlinks. Since we follow symlinks by default (unless disabled by setting fileserver_folllowsymlinks to False) when walking the fileserver directories, this results in a lot of extra work, and the thought was that this was being compounded by repeating this work in the symlink_list() function. However, I never got a chance to test that hypothesis.

Either way, even if it doesn't fully solve that problem, it will still have a positive impact when symlinks are present.

@ninja-
Copy link
Contributor

ninja- commented Feb 12, 2017

Ah ok. Thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants