Add cp.push test #39362
Merged
Add cp.push test #39362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtmanfred I've created a new PR to 2016.3 as you advised here #39353 |
dincamihai
force-pushed
the
cp-push-test-2016.3
branch
from
2f8d288
to
c557e65
Compare
|
Thanks for adding this test @dincamihai. There are some lint errors that need to be cleaned up. Can you take a look at those? Context management in Python 2.6 needs the |
dincamihai
force-pushed
the
cp-push-test-2016.3
branch
2 times, most recently
from
4ab98d6
to
12f891a
Compare
dincamihai
force-pushed
the
cp-push-test-2016.3
branch
from
12f891a
to
91383c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add test for calling cp.push with correct arguments.
What issues does this PR fix or reference?
I've also found out that there's no test for checking that
cp.pushis working when passing the right arguments, so I wrote one.Tests written?
Yes