Prevents 'OSError' exception in case certain job cache path doesn't exist #39400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue that may occur when exploring the local salt jobs cache.
If
master
has certain workload, or salt job cache is cleaned while i.a.jobs.list_jobs
is running, then we're going to get anOSError
exception due non-existing path.The
_walk_through
loop is not checking the actual existence of thet_path
before accessing it. We should ensure that such path is existing just before callingos.listdir()
.Same is already done for the final job file just before open it.
Tests written?
No
/cc @moio