Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default permission modes for file module #39487

Merged
merged 1 commit into from Feb 24, 2017

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Feb 17, 2017

What does this PR do?

Documents default permission modes for file module.

What issues does this PR fix or reference?

@cachedout
Copy link
Contributor

Hmm, I wonder if a better and more accurate way to put this would be that the default permissions correspond to the umask of the user under which Salt is running.

@bobrik
Copy link
Contributor Author

bobrik commented Feb 20, 2017

Just to confirm, is this what you are proposing?

Instead of this:

  • The default mode for files is 0644.

You suggest something like this (I added more details for clarity):

  • The default mode for new files corresponds umask of salt process. For existing files it's not enforced.

@cachedout
Copy link
Contributor

@bobrik Correct.

@bobrik
Copy link
Contributor Author

bobrik commented Feb 23, 2017

Updated. I used the same universal paragraph everywhere to make it easier to find and change.

@cachedout cachedout merged commit 3f8b5e6 into saltstack:2016.3 Feb 24, 2017
@cachedout
Copy link
Contributor

Thanks, @bobrik !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants