Implement no_block for service.running/service.dead (systemd only) #39632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terminalmage, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thatch45, @kiorky and @robertkeizer to be potential reviewers. |
lmb
reviewed
Feb 24, 2017
| python_shell=False, | ||
| ignore_recode=True) == 0 |
There was a problem hiding this comment.
Seems like this is an unrelated bugfix? Might be worth calling that out?
There was a problem hiding this comment.
I don't know what you mean by "calling that out".
If you mean "mention it in the PR/commit msg", I don't think that's necessary since I opened #39633 to fix this in the 2016.3 release branch. I only made the change here because I also added a missing unit test, and I needed this fix here to make the test pass.
|
Great! Just checking :)
|
|
Cool. Thanks for reviewing the PR, by the way. 😄 |
|
@terminalmage Could you rebase this please? Merge conflict. |
terminalmage
force-pushed
the
issue39570
branch
from
0e30311
to
f6b9152
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39570.