Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misspelled argument in salt.modules.systemd.disable() #39633

Merged
merged 2 commits into from
Feb 24, 2017
Merged

Fix misspelled argument in salt.modules.systemd.disable() #39633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17109e1
Fix misspelled argument in salt.modules.systemd.disable()
terminalmage Feb 24, 2017
ca54541
Add missing unit test for disable func
terminalmage Feb 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion salt/modules/systemd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ def disable(name, **kwargs): # pylint: disable=unused-argument
return __salt__['cmd.retcode'](
_systemctl_cmd('disable', name, systemd_scope=True),
python_shell=False,
ignore_recode=True) == 0
ignore_retcode=True) == 0


# The unused kwargs argument is required to maintain consistency with the API
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/modules/systemd_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ def test_force_reload(self):
def test_enable(self):
self._change_state('enable')

def test_disable(self):
self._change_state('disable')

def test_mask(self):
self._mask_unmask('mask', False)

Expand Down