Turn on sign_pub_messages by default. #40159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' are dropped with error when sign_pub_messages is True.
|
@cro, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jacksontj, @s0undt3ch and @cachedout to be potential reviewers. |
|
FTR I did performance testing with this on and off. Performance impact with 120 minions is minimal on 2016.3, almost nonexistent in 2016.11 and following. |
s0undt3ch
approved these changes
Mar 20, 2017
|
Go Go Jenkins! |
cachedout
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure messages with no 'sig' are dropped with error when sign_pub_messages is True.
Tests written?
Tests are already present for sign_pub_messages.