Fix bug #42936 - win_iis module container settings

[Mapel88]

What does this PR do?

Fix bug #42936 - win_iis module container settings

What issues does this PR fix or reference?

fix container appPools identity type setting:

• support string / numeric for server 2008 fixed
• action completed validation test fixed

Previous Behavior

• to set identity type in server 2008 need to use numeric id
• the validation test failed cause it compared string & numeric

Tests written?

NO

Please review Salt's Contributing Guide for best practices.

[ghost]

@Mapel88, thanks for your PR! By analyzing the history of the files in this pull request, we identified @m03, @twangboy and @trebortech to be potential reviewers.

[cachedout]

Hi @Mapel88. Thanks for this. Could you please fix these lint errors before we merge this? Thanks.

https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/13905/violations/

[Mapel88]

Hi @cachedout
I'm sorry but I don't know where are the lint errors.
If you could tell me which lines needs to be fixed I'll do it.

thanks

[cachedout]

Hi @Mapel88

They can be seen here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/13905/violations/file/salt/states/win_iis.py/

and:

https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/13905/violations/file/salt/modules/win_iis.py/

Thanks.

[cachedout]

Hi @Mapel88. Thanks for those fixes. There are still a handful of lint errors that remain though. Please let us know if you need any help clearing those up and we'll happily assist. Thanks!

[Mapel88]

@cachedout - Would appreciate it.
I don't know how to identify those lint errors unless you specifically tell me what they are..

Thanks! :)

[twangboy]

@Mapel88 https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/14005/violations/