Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes updates v2 #44405

Merged
merged 6 commits into from Nov 7, 2017
Merged

Commits on Nov 5, 2017

  1. Add the beginning of tests for states.kubernetes and update things

    * Add 100% test coverage for the kubernetes.secret_present state
    * Add 100% test coverage for the kubernetes.configmap_absent state
    * Add 100% test coverage for the kubernetes.configmap_present state
    * Make some fields optional to kubernetes.create_secret and add examples
    * Make some fields optional to kubernetes.replace_secret and add examples
    * Make some fields optional to kubernetes.create_configmap and add examples
    * Make some fields optional to kubernetes.replace_configmap and add examples
    * Add 'comment' when a kubernetes configmap or secret is going to be replaced
    * Update 'source', 'template', and 'saltenv' kwargs to defaults from the rest of the codebase
    * Allow passing empty 'data' to the kubernetes.configmap_present state to remove the existing contents
    SEJeff committed Nov 5, 2017
    Copy the full SHA
    2b02a46 View commit details
    Browse the repository at this point in the history
  2. More kubernetes state tests

    * Add 100% test coverage for the kubernetes.secret_absent state
    * Add 100% coverage for kubernetes.node_label_present
    * Also add 'comment' to kubernetes.node_add_label
    * Make the faux test objects more believable in test_kubernetes.py
    SEJeff committed Nov 5, 2017
    Copy the full SHA
    7039d74 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2017

  1. Fix a bug in the kubernetes.namespace_present state

    This bug found courtesy of writing unit tests to ensure it worked! When
    a namespace is created via `kubernetes.namespace_present`, the 'result'
    key of the return dict stays the default of `False`, which is confusing
    after it is actually created.
    
    TDD, finding your problems, just like mom!
    SEJeff committed Nov 6, 2017
    Copy the full SHA
    dda5879 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c08faa1 View commit details
    Browse the repository at this point in the history
  3. Small formatting fixup

    SEJeff committed Nov 6, 2017
    Copy the full SHA
    2b44f7c View commit details
    Browse the repository at this point in the history
  4. Up the total test coverage of the kubernetes state to 54%!

    * Add 100% test coverage for the kubernetes.node_label_absent state
    * Add 100% test coverage for the kubernetes.namespace_present state
    * Add 100% test coverage for the kubernetes.namespace_absent state
    SEJeff committed Nov 6, 2017
    Copy the full SHA
    eaaa4dc View commit details
    Browse the repository at this point in the history