Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] Fix docstring integration test failure #45200

Merged
merged 1 commit into from Dec 28, 2017

Conversation

rallytime
Copy link
Contributor

What does this PR do?

Fixes the following test failure:

  • integration.modules.test_sysmod.SysModuleTest.test_valid_docs

What issues does this PR fix or reference?

This was introduced with #44552.

@rallytime rallytime merged commit 2e18398 into saltstack:2017.7 Dec 28, 2017
@rallytime rallytime deleted the fix-docstring-test-failure branch December 28, 2017 22:58
@sathieu
Copy link
Contributor

sathieu commented Nov 8, 2018

A similar bug is currently happening only on win2016-py2:

03:06:47        ============================  Overall Tests Report  ============================
03:06:47        *** integration.modules.test_sysmod Tests  *************************************
03:06:47         --------  Tests with Errors  --------------------------------------------------
03:06:47           -> integration.modules.test_sysmod.SysModuleTest.test_valid_docs  ...........
03:06:47        Traceback (most recent call last):
03:06:47          File "c:\users\admini~1\appdata\local\temp\kitchen\testing\tests\integration\modules\test_sysmod.py", line 29, in test_valid_docs
03:06:47            '\n'.join(['  - {0}'.format(f) for f in ret['missing_docstring']]),
03:06:47        TypeError: 'bool' object has no attribute '__getitem__'
03:06:47           .............................................................................
03:06:47         -------------------------------------------------------------------------------
03:06:47        ================================================================================
03:06:47        FAILED (total=1, skipped=0, passed=0, failures=0, errors=1) 
03:06:47        ============================  Overall Tests Report  ============================

Any idea how to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants