Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aptpkg: apt-add-repository: Use proxy for PPA #45224

Merged
merged 2 commits into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@alexandruavadanii
Copy link
Contributor

commented Dec 30, 2017

What does this PR do?

Extend proxy support for APT repository handling to PPA addition
via apt-add-repository.

What issues does this PR fix or reference?

Adding 'ppa: repo' behind a proxy fails.

Previous Behavior

Proxy support works for all APT repos, as long as they are not added in 'ppa: repo' form.
When 'ppa: repo' is used, apt-add-repository is called without the proper http(s)_proxy env vars set and fails (after a very long timeout).

New Behavior

Works as expected.

Tests written?

No

Commits signed with GPG?

Yes

aptpkg: apt-add-repository: Use proxy for PPA
Extend proxy support for APT repository handling to PPA addition
via `apt-add-repository`.

Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>

@rallytime rallytime requested a review from garethgreenaway Jan 2, 2018

@rallytime rallytime merged commit 45903a7 into saltstack:develop Jan 8, 2018

5 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #18269 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #5275 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #14827 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #20762 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13243 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #17839 — SUCCESS
Details

@alexandruavadanii alexandruavadanii deleted the alexandruavadanii:ppa-use-proxy branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.