aptpkg: apt-add-repository: Use proxy for PPA #45224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend proxy support for APT repository handling to PPA addition via `apt-add-repository`. Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
rallytime
approved these changes
Jan 2, 2018
garethgreenaway
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extend proxy support for APT repository handling to PPA addition
via
apt-add-repository.What issues does this PR fix or reference?
Adding 'ppa: repo' behind a proxy fails.
Previous Behavior
Proxy support works for all APT repos, as long as they are not added in 'ppa: repo' form.
When 'ppa: repo' is used,
apt-add-repositoryis called without the proper http(s)_proxy env vars set and fails (after a very long timeout).New Behavior
Works as expected.
Tests written?
No
Commits signed with GPG?
Yes