[DOC] Replace note rST block for GitHub
#46214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vutny I don't think we want to change that here because the file is an I changed it in the salt-bootstrap file because we don't actually build those docs anywhere to use the rst syntax. |
|
@rallytime I think you'd not build that particular README file since it is embedded in own block. So it does not affect building properly formatted formulas page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
noterST block in favor of just bold heading text in example of README file at formulas doc page.It seems neither GitHub, nor Bitbucket does not properly support it and the rendered text does not look expressive. Same thing was done previously in saltstack/salt-bootstrap repository.
Commits signed with GPG?
Yes