states.user.present: Make usage of hash_password idempotent
#47147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those failures aren't related to this PR: |
|
I totally see the case for this but would love to have some tests written around this behavior. Any chance you'd be willing to write some? |
|
@eliasp Did you see my comment above regarding tests? |
|
Sorry, I initially planned on adding some tests, but won't have time right now to complete this.
|
cachedout
approved these changes
May 1, 2018
isbm
suggested changes
May 1, 2018
| # hash to change each time and thereby making the | ||
| # user.present state non-idempotent. | ||
| algorithms = { | ||
| '1': 'md5', |
There was a problem hiding this comment.
But this is insecure. I think we should either kill this option or at least scream all around the place in logs if anyone will use this.
There was a problem hiding this comment.
I do agree that "screaming all around the place in logs" is the most reasonable reaction here…
Added a corresponding warning.
isbm
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the non-idempotent behavior of
states.user.presentwhenhash_password: Truedescribed in #45939It targets
2018.3, but due to it's trivial nature, it should be easily cherry-picked for backports to older releases.What issues does this PR fix or reference?
#45939
Previous Behavior
Every time
states.user.presentwithhash_password: Truewas used, a new shadow hash was generated based on a new randomly generated salt value for hashing which made this state's behavior idempotent.New Behavior
Before hashing a password, it checks now whether an existing salt can be retrieved.
If yes, it will be re-used for generating the hash.
If not, it defaults to using a new randomly generated salt.
Tests written?
No
Commits signed with GPG?
Yes