[2018.3] Fixes to salt_proxy beacon and beacon tests #47255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
approved these changes
Apr 24, 2018
|
@garethgreenaway A couple of related test failures that need to be adjusted a bit further on this one: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/22105/ |
…ration is valid. Update various beacon unit tests to ensure they are testing the results of the validate function for a True result.
garethgreenaway
force-pushed
the
47239_fixes_to_salt_proxy_beacon
branch
from
f4cf7ae
to
a2a8d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure the salt_proxy is returning the correct tuple when the configuration is valid. Update various beacon unit tests to ensure they are testing the results of the validate function for a True result.
What issues does this PR fix or reference?
#47239
Tests written?
Yes. Existing tests updated.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.