Fix non-root build and signing for rpm packages #47545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
force-pushed
the
fix_nonroot_build
branch
2 times, most recently
from
9bd6292
to
45fa27a
Compare
dmurphy18
force-pushed
the
fix_nonroot_build
branch
from
45fa27a
to
a36de5c
Compare
|
re-run py2 |
terminalmage
suggested changes
May 16, 2018
salt/modules/rpmbuild.py
Outdated
| srpms = os.path.join(tree_base, 'SRPMS') | ||
| ret = [] | ||
| if not os.path.isdir(dest_dir): | ||
| os.makedirs(dest_dir) | ||
| __salt__['file.chown'](path=dest_dir, user=runas, group='mock') |
There was a problem hiding this comment.
This appears to be chown'ing a directory that doesn't exist, since you have removed the os.makedirs(dest_dir)
There was a problem hiding this comment.
Thanks for the catch, that looks like it should have been makedirs_perms, will fix
added 4 commits
May 16, 2018 09:45
dmurphy18
force-pushed
the
fix_nonroot_build
branch
from
a36de5c
to
220f887
Compare
|
@terminalmage There is a change coming from a contributor see #47056, so minimizing merge (user vs runas) when that is delivered. Post merge can update both debbuild.py and rpmbuild.py, as the contributor is also updating debbuild.py. Also reluctant to change preexisting code for new naming scheme in minor release, fix up in develop after merge. |
terminalmage
approved these changes
May 17, 2018
|
re-run py2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores the ability to build and sign packages for rpm builds as a non-root user
This ability was changed in the Nitrogen release.
What issues does this PR fix or reference?
vmware-archive/salt-pack#545
Previous Behavior
Could only perform builds and signing for rpm packages as root since 2017.7.0
New Behavior
Restores ability to perform builds and signing for rpm packages as non-root user, for example: builder, with Salt minions as prior to the 2017.7.0 release.
Tests written?
No, built and signed Centos 7 packages.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.