Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix non-root build and signing for rpm packages #47545
What does this PR do?
Restores the ability to build and sign packages for rpm builds as a non-root user
What issues does this PR fix or reference?
Could only perform builds and signing for rpm packages as root since 2017.7.0
Restores ability to perform builds and signing for rpm packages as non-root user, for example: builder, with Salt minions as prior to the 2017.7.0 release.
No, built and signed Centos 7 packages.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
2 times, most recently
May 8, 2018
One small problem here. Also, I thought we standardized on using
user instead of
runas everywhere else beside
@terminalmage There is a change coming from a contributor see #47056, so minimizing merge (user vs runas) when that is delivered. Post merge can update both debbuild.py and rpmbuild.py, as the contributor is also updating debbuild.py.
Also reluctant to change preexisting code for new naming scheme in minor release, fix up in develop after merge.