New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query the pip path for test test_issue_2087_missing_pip #47645

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented May 14, 2018

What does this PR do?

The following tests are failing on macosx python3:

integration.modules.test_pip.PipModuleTest.test_issue_2087_missing_pip                                                                                                              
integration.states.test_pip.PipStateTest.test_issue_2087_missing_pip

This is because when the virtualenv is created its created with python2 because the default python is 2 on the macosx hosts. My understanding of the virtualenv.create module is that it will use the default python version installed unless python=python3 is passed to the command. I could be wrong about this code analysis as I am not certain if its suppose to grab the version of python that salt is running.

This PR changes the test to query what the site-packages path is for the pip package before we try to remove it, instead of assuming the path is the same version of python as the test runner.

@Ch3LL Ch3LL requested a review from twangboy May 14, 2018

@twangboy

This comment has been minimized.

Contributor

twangboy commented May 15, 2018

@Ch3LL Actually I think the version of is bundled within virtualenv itself and does not rely on the System python. At least that's what I think @terminalmage and I worked out.

@rallytime rallytime merged commit a4921e8 into saltstack:2017.7.6 May 15, 2018

6 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4892 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18948 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25072 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17180 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22824 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9862 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21804 — SUCCESS
Details

rallytime added a commit that referenced this pull request May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment