Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up doc build warnings, add best practices for writing states #47860

Merged
merged 10 commits into from Jun 1, 2018
Merged

Clean up doc build warnings, add best practices for writing states #47860

merged 10 commits into from Jun 1, 2018

Commits on May 31, 2018

  1. Clarify that name would override the id declaration

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    64b9b4d View commit details
    Browse the repository at this point in the history

  2. Fix all Sphinx warnings 

    Well, all but one, which we expect to see
    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    93ee5ee View commit details
    Browse the repository at this point in the history

  3. Add best practices docs for writing states

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    f465fa3 View commit details
    Browse the repository at this point in the history

  4. Improve documentation on syncing states

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    9dddeee View commit details
    Browse the repository at this point in the history

  5. Add 2017.7.6 release notes

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    d37f7e4 View commit details
    Browse the repository at this point in the history

  6. Lint fixes

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    bc9e3ac View commit details
    Browse the repository at this point in the history

  7. Fix crappy mocking 

    This fixes some poorly-conceived mocking that was done because of some
equally dumb imports being done in salt/modules/junos.py (which I fixed
a few commits ago while in the process of cleaning up the docs).
    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    b9ace5a View commit details
    Browse the repository at this point in the history

  8. Update mocking to reflect changes in service module

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    91cd57d View commit details
    Browse the repository at this point in the history

  9. Use more elegant RST syntax

    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    af51e16 View commit details
    Browse the repository at this point in the history

  10. Quiet the linter 

    We need this import to determine whether we have the needed modules to
run the test, even though it is not invoked directly.
    @terminalmage
    terminalmage committed May 31, 2018
    Copy the full SHA
    8cb33d3 View commit details
    Browse the repository at this point in the history