Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert job chunk wait time change #47877

Merged
merged 1 commit into from Jun 1, 2018
Merged

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented May 29, 2018

What does this PR do?

Reverting the sleep time from 0.0001 back to 0.01, sleeping such a short
amount of time eats up CPU resources needlessly.

What issues does this PR fix or reference?

Previous Behavior

Sleeping 0.0001 seconds eats about 25% of a 2Ghz core.

New Behavior

Sleeping less allows things to run smoothly and preserves resources for things needing them.

Tests written?

No

Commits signed with GPG?

Yes

Reverting the sleep time from 0.0001 back to 0.01, sleeping such a short
amount of time eats up CPU resources needlessly.
@ghost ghost self-requested a review May 29, 2018 19:40
@dwoz dwoz requested review from terminalmage, gtmanfred and rallytime and removed request for a team May 29, 2018 19:40
@dwoz
Copy link
Contributor Author

dwoz commented May 29, 2018

re-run py

1 similar comment
@rallytime
Copy link
Contributor

re-run py

@rallytime
Copy link
Contributor

@terminalmage Can you review this one when you get a moment?

@gtmanfred gtmanfred merged commit d2f3377 into saltstack:2017.7 Jun 1, 2018
@dwoz dwoz deleted the sleep_audit branch August 21, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants