New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert job chunk wait time change #47877

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
4 participants
@dwoz
Contributor

dwoz commented May 29, 2018

What does this PR do?

Reverting the sleep time from 0.0001 back to 0.01, sleeping such a short
amount of time eats up CPU resources needlessly.

What issues does this PR fix or reference?

Previous Behavior

Sleeping 0.0001 seconds eats about 25% of a 2Ghz core.

New Behavior

Sleeping less allows things to run smoothly and preserves resources for things needing them.

Tests written?

No

Commits signed with GPG?

Yes

Revert job chunk wait time change
Reverting the sleep time from 0.0001 back to 0.01, sleeping such a short
amount of time eats up CPU resources needlessly.

@salt-jenkins salt-jenkins requested a review from saltstack/team-state May 29, 2018

@dwoz dwoz requested review from terminalmage, gtmanfred and rallytime and removed request for saltstack/team-state May 29, 2018

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 29, 2018

re-run py

1 similar comment
@rallytime

This comment has been minimized.

Contributor

rallytime commented May 30, 2018

re-run py

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 31, 2018

@terminalmage Can you review this one when you get a moment?

@gtmanfred gtmanfred merged commit d2f3377 into saltstack:2017.7 Jun 1, 2018

6 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5360 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19416 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25556 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17614 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23294 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10331 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22244 — SUCCESS
Details

@dwoz dwoz deleted the dwoz:sleep_audit branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment