New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to mysql module #48228

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
2 participants
@garethgreenaway
Member

garethgreenaway commented Jun 20, 2018

What does this PR do?

Updating the mysql module to not use the PASSWORD when MySQL is version 8.0.11 or higher, where the PASSWORD function has been removed.

What issues does this PR fix or reference?

#48204

Tests written?

Yes. Existing tests updated.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Updating the mysql module to not use the PASSWORD when MySQL is versi…
…on 8.0.11 or higher, where the PASSWORD function has been removed.
@garethgreenaway

This comment has been minimized.

Member

garethgreenaway commented Jun 21, 2018

re-run centos

@rallytime rallytime merged commit 09b036c into saltstack:2018.3 Jun 22, 2018

7 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19996 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26147 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18150 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5943 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23823 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10865 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22785 — SUCCESS
Details
@garethgreenaway

This comment has been minimized.

Member

garethgreenaway commented Jun 22, 2018

@rallytime looks like this fix wasn't correct. I'll be looking at it more this morning.

@rallytime

This comment has been minimized.

Contributor

rallytime commented Jun 22, 2018

@garethgreenaway Ah, drat. I usually try to remember to check the linked issues, but I forgot this time. Thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment