Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virt states improvements #48421

Merged
merged 8 commits into from Jul 9, 2018
Merged

Virt states improvements #48421

merged 8 commits into from Jul 9, 2018

Commits on Jul 3, 2018

  1. Add test case for virt.running 

    Test virt.running when the domain needs to be edited and started. This
will prevent regressions when improving virt.running to handle the new
virt.init parameters.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    495db34 View commit details
    Browse the repository at this point in the history

  2. virt.running support for all virt.init options 

    virt.running actually calls virt.init if the virtual machine doesn't
exist. Let the user define all the virt.init possible options in his
running states too.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    cb00a5f View commit details
    Browse the repository at this point in the history

  3. Add connection parameters to virt states 

    Since the virt module allows the user to override the connection
parameters, bubble these changes to the non-deprecated virt states.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    580164b View commit details
    Browse the repository at this point in the history

  4. Align virt network definition functions with others 

    Rename execution module virt.net_define in virt.network_define and
state virt.network_define into virt.network_running. Also fix the
network_running state to match the virt.running implementation style.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    4b7fb5c View commit details
    Browse the repository at this point in the history

  5. Allow defining more virtual storage pool types 

    The virt.pool_define template is way too limited to handle all possible
libvirt pool types. Add some more parameters to cover them all.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    ff07f71 View commit details
    Browse the repository at this point in the history

  6. Align virt.pool_define state with domains 

    Change the function name to pool_running since that state ensures the
pool is running, rather than just defining it. Also change the
implementation to match the one from virt.running() to keep consistent
across the module.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    740744a View commit details
    Browse the repository at this point in the history

  7. Add missing virt states unit tests 

    So far only the virt.running state is unit tested. Add tests for the
other states. Deprecated virt states have been purposedly left untested.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    fc75872 View commit details
    Browse the repository at this point in the history

  8. Remove unneeded kwargs in virt states 

    Avoid using kwargs to get the states parameters, perfer documented
named parameters with default value.
    @cbosdo
    cbosdo committed Jul 3, 2018
    Copy the full SHA
    c7c5d6e View commit details
    Browse the repository at this point in the history