Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a pair of Proxy and Execution modules for managing Cisco Nexus switches via the NX-API #48541

Merged
merged 2 commits into from Jul 16, 2018

Conversation

Projects
None yet
3 participants
@mirceaulinic
Copy link
Member

commented Jul 12, 2018

What does this PR do?

Adds the initial version of two new modules: one Proxy and one Execution module for managing Cisco Nexus switches via via NX-API. Well, the NX-API is not the most reliable API in this world, but it's there and it can be used up to some extent.

The execution module is flexible enough to execute the commands on the (remote) device without necessarily requiring to be running inside the nxos_api Proxy Minion. This goes well with its SSH-based counterpart https://docs.saltstack.com/en/latest/ref/modules/all/salt.modules.nxos.html providing good coverage for NXOS switches.

The most important side of these modules is the fact that it has no external dependencies, as everything is HTTP-based. Not only that it's easier to get it up and running, but that also means it's straight forward to have it running under a regular Minion: on Nexus switches it is possible to install the Salt Minion under a container running in a what-is-called OAC (why keep it simple when can you make it awkward, right?). Anyway, the idea is that the user only has to execute yum install salt-minion in that OAC, then can start using: salt-call --local nxos_api.show 'show bgp sessions' without any further headache.
If, for whatever reasons, the user can't / is not allowed / the hardware does not support the OAC thing, can always fallback to using the nxos_api Proxy instead.

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:nxos-api-mod branch 4 times, most recently from bdb7944 to 075cfcf Jul 12, 2018

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:nxos-api-mod branch from 075cfcf to e69877e Jul 12, 2018

@gtmanfred
Copy link
Contributor

left a comment

blind-review

@rallytime rallytime merged commit ff3ff80 into saltstack:develop Jul 16, 2018

6 of 17 checks passed

continuous-integration/jenkins/pr-merge The build of this commit was aborted
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11362 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20445 — ABORTED
Details
codeclimate 8 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6392 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24320 — FAILURE
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/lint Testing lint...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26607 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18637 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23273 — SUCCESS
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

@mirceaulinic mirceaulinic deleted the mirceaulinic:nxos-api-mod branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.