Skip to content

Conversation

@mirceaulinic
Copy link
Contributor

What does this PR do?

Adding a new execution module to manipulate JIRA tickets - very useful to dynamically create tickets as in response to various events (e.g., create ticket on interface down, or on server reboot etc.).

@mirceaulinic mirceaulinic changed the title Adding a new execution module to manipular JIRA tickets Adding a new execution module to manipulate JIRA tickets Jul 20, 2018
@damon-atkins
Copy link
Contributor

Please rename jira_mod to atlassian_jira

Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing to fix, otherwise this looks good to me. The name of the module is fine with me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print_function and unicode_literals need to be added here for imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed @rallytime

@damon-atkins
Copy link
Contributor

Reason for the name change e.g. atlassian_jira is so other atlassian modules can have the name atlassian_* pattern. And also mod not need in the name of a module as its in the module directory.

@cachedout
Copy link
Contributor

I don't agree with the proposed naming. We don't, for example, name the apache module apache_foundation_apache simply because the Apache Foundation produces other software. Jira is well-known on its own and I just don't see how including the vendor name adds any clarity or organizational value.

@rallytime rallytime merged commit 8958c30 into saltstack:develop Jul 24, 2018
@mirceaulinic mirceaulinic deleted the jira-mod branch July 25, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants