Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new execution module to manipulate JIRA tickets #48687

Merged
merged 3 commits into from Jul 24, 2018

Conversation

Projects
None yet
4 participants
@mirceaulinic
Copy link
Member

commented Jul 20, 2018

What does this PR do?

Adding a new execution module to manipulate JIRA tickets - very useful to dynamically create tickets as in response to various events (e.g., create ticket on interface down, or on server reboot etc.).

@mirceaulinic mirceaulinic changed the title Adding a new execution module to manipular JIRA tickets Adding a new execution module to manipulate JIRA tickets Jul 20, 2018

@damon-atkins

This comment has been minimized.

Copy link
Member

commented Jul 22, 2018

Please rename jira_mod to atlassian_jira

@rallytime
Copy link
Contributor

left a comment

One small thing to fix, otherwise this looks good to me. The name of the module is fine with me.

username: salt
password: pass
'''
from __future__ import absolute_import

This comment has been minimized.

Copy link
@rallytime

rallytime Jul 23, 2018

Contributor

print_function and unicode_literals need to be added here for imports

This comment has been minimized.

Copy link
@mirceaulinic

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:jira-mod branch from eeaa167 to 2ae5a26 Jul 23, 2018

@damon-atkins

This comment has been minimized.

Copy link
Member

commented Jul 23, 2018

Reason for the name change e.g. atlassian_jira is so other atlassian modules can have the name atlassian_* pattern. And also mod not need in the name of a module as its in the module directory.

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2018

I don't agree with the proposed naming. We don't, for example, name the apache module apache_foundation_apache simply because the Apache Foundation produces other software. Jira is well-known on its own and I just don't see how including the vendor name adds any clarity or organizational value.

@rallytime rallytime merged commit 8958c30 into saltstack:develop Jul 24, 2018

3 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
codeclimate 4 issues to fix
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@mirceaulinic mirceaulinic deleted the mirceaulinic:jira-mod branch Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.