Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new execution module to manipulate JIRA tickets #48687

Merged
merged 3 commits into from Jul 24, 2018

Conversation

@mirceaulinic
Copy link
Member

@mirceaulinic mirceaulinic commented Jul 20, 2018

What does this PR do?

Adding a new execution module to manipulate JIRA tickets - very useful to dynamically create tickets as in response to various events (e.g., create ticket on interface down, or on server reboot etc.).

@mirceaulinic mirceaulinic changed the title Adding a new execution module to manipular JIRA tickets Adding a new execution module to manipulate JIRA tickets Jul 20, 2018
@damon-atkins
Copy link
Collaborator

@damon-atkins damon-atkins commented Jul 22, 2018

Please rename jira_mod to atlassian_jira

Copy link
Contributor

@rallytime rallytime left a comment

One small thing to fix, otherwise this looks good to me. The name of the module is fine with me.

username: salt
password: pass
'''
from __future__ import absolute_import
Copy link
Contributor

@rallytime rallytime Jul 23, 2018

print_function and unicode_literals need to be added here for imports

Copy link
Member Author

@mirceaulinic mirceaulinic Jul 23, 2018

Fixed @rallytime

@damon-atkins
Copy link
Collaborator

@damon-atkins damon-atkins commented Jul 23, 2018

Reason for the name change e.g. atlassian_jira is so other atlassian modules can have the name atlassian_* pattern. And also mod not need in the name of a module as its in the module directory.

@cachedout
Copy link
Contributor

@cachedout cachedout commented Jul 23, 2018

I don't agree with the proposed naming. We don't, for example, name the apache module apache_foundation_apache simply because the Apache Foundation produces other software. Jira is well-known on its own and I just don't see how including the vendor name adds any clarity or organizational value.

@rallytime rallytime merged commit 8958c30 into saltstack:develop Jul 24, 2018
3 of 8 checks passed
@mirceaulinic mirceaulinic deleted the jira-mod branch Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants