Adding a new execution module to manipulate JIRA tickets #48687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceaulinic
changed the title
|
Please rename jira_mod to atlassian_jira |
rallytime
suggested changes
Jul 23, 2018
salt/modules/jira_mod.py
Outdated
| username: salt | ||
| password: pass | ||
| ''' | ||
| from __future__ import absolute_import |
There was a problem hiding this comment.
print_function and unicode_literals need to be added here for imports
There was a problem hiding this comment.
Fixed @rallytime
rallytime
approved these changes
Jul 23, 2018
|
Reason for the name change e.g. atlassian_jira is so other atlassian modules can have the name atlassian_* pattern. And also mod not need in the name of a module as its in the module directory. |
|
I don't agree with the proposed naming. We don't, for example, name the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding a new execution module to manipulate JIRA tickets - very useful to dynamically create tickets as in response to various events (e.g., create ticket on interface down, or on server reboot etc.).