Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ldap authentication with starttls #48697

Merged
merged 1 commit into from Jul 23, 2018

Conversation

@dgengtek
Copy link
Contributor

@dgengtek dgengtek commented Jul 21, 2018

fix #48655

What does this PR do?

Add starttls support for ldap authentication module

What issues does this PR fix or reference?

issue 48655

New Behavior

support starttls protocol and check if either only starttls or tls is enabled

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dgengtek dgengtek requested a review from as a code owner Jul 21, 2018
@ghost ghost self-requested a review Jul 21, 2018
@dgengtek dgengtek force-pushed the feature/ldap-starttls branch from e48d25f to aa6458e Jul 21, 2018
@dwoz
Copy link
Contributor

@dwoz dwoz commented Jul 21, 2018

This is a bit off topic. However, I see we are calling simple_bind_s but I can not find an unbind_s call anywhere. I think we should look into cleaning up the connection properly by having a corresponding unbind to any bind that happens.

@cachedout
Copy link
Contributor

@cachedout cachedout commented Jul 23, 2018

@dwoz Agreed but let's have you file that as a separate issue, please. I think this is PR is good as it sits.

@rallytime
Copy link
Contributor

@rallytime rallytime commented Jul 23, 2018

Thanks @dgengtek and congrats on your first Salt PR! :)

@rallytime rallytime merged commit 031741f into saltstack:develop Jul 23, 2018
4 of 9 checks passed
@dgengtek
Copy link
Contributor Author

@dgengtek dgengtek commented Jul 27, 2018

@rallytime thanks, you guys are quick 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants