Feature: ldap authentication with starttls #48697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
dgengtek
force-pushed
the
feature/ldap-starttls
branch
from
e48d25f
to
aa6458e
Compare
|
This is a bit off topic. However, I see we are calling |
cachedout
approved these changes
Jul 23, 2018
|
@dwoz Agreed but let's have you file that as a separate issue, please. I think this is PR is good as it sits. |
|
Thanks @dgengtek and congrats on your first Salt PR! :) |
|
@rallytime thanks, you guys are quick 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #48655
What does this PR do?
Add starttls support for ldap authentication module
What issues does this PR fix or reference?
issue 48655
New Behavior
support starttls protocol and check if either only starttls or tls is enabled
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.