New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate compound matcher tests into individual tests #48884

Merged
merged 2 commits into from Aug 2, 2018

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Aug 2, 2018

When one match fails (and some of these can be flaky) the whole test fails.

This makes it somewhat difficult to track down why the test fails.

I am hoping we won't need the sleeps in this change when the tests are separate, but let's see how that goes. It worked fine in my testing.

I also updated the test to use pytest notation, rather than unittest.

Separate compound matcher tests into individual tests
When one match fails (and some of these can be flaky) the whole test fails.

This makes it somewhat difficult to track down why the test fails.

I am hoping we won't need the sleeps in this change when the tests are separate,
but let's see how that goes. It worked fine in my testing.

I also updated the test to use pytest notation, rather than unittest.

@rallytime rallytime requested a review from saltstack/team-core Aug 2, 2018

@rallytime rallytime merged commit bf08956 into saltstack:2017.7 Aug 2, 2018

7 of 8 checks passed

jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@rallytime rallytime deleted the rallytime:flaky-tests-matchers branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment