Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Two more options added to the netbox Pillar, and use salt.utils.http #48910
What does this PR do?
I am applying some small (or I think so) changes to the
@ksofa2 @ngrundler I hope you don't mind my changes, please let me know if there's anything you disagree / should be changed etc. Additionally, it would be great if you could test this out and confirm it doesn't change anything in your environment. Thanks!
No issues on my end, this looks great. A good learning example for me about how I can use features built into salt to remove dependencies and make things simpler!
What do you think about nesting the different NetBox API endpoints into the
I've since made some tweaks internally since we're trying to use netbox data to drive configuration templates and I needed this data available, so I have set up queries to interfaces, addresses, connections, etc. I was planning on adding this to the module myself soon(ish), but I see no reason for that to impact this PR.
I think that's a great idea, but I'd nest them in the App endpoint as well. So instead of the flatter structure you proposed, I propose:
This will make sure there's no conflicts if/when Netbox has 2 apps with identical API endpoints.