New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_runas integration test for macosx #48928

Merged
merged 4 commits into from Aug 5, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented Aug 3, 2018

What does this PR do?

The test integration.modules.test_cmdmod.CMDModuleTest.test_runas which was recently added is failing on macosx because it can't use the nobody user. Adding some setup and teardown logic which will add a mac user to test the runas functionality.

Ch3LL added some commits Aug 3, 2018

@Ch3LL

This comment has been minimized.

Contributor

Ch3LL commented Aug 3, 2018

wait found an issue with my fix. dont merge yet

Ch3LL added some commits Aug 3, 2018

@Ch3LL

This comment has been minimized.

Contributor

Ch3LL commented Aug 3, 2018

k good to go now

@rallytime rallytime merged commit abd7f13 into saltstack:2018.3 Aug 5, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment