Skip to content

add lxd tests#49032

Merged
rallytime merged 4 commits into
saltstack:fluorinefrom
gtmanfred:fluorine
Aug 13, 2018
Merged

add lxd tests#49032
rallytime merged 4 commits into
saltstack:fluorinefrom
gtmanfred:fluorine

Conversation

@gtmanfred

Copy link
Copy Markdown
Contributor

What does this PR do?

Add tests for LXD

What issues does this PR fix or reference?

Closes #46846

Tests written?

Yes

Commits signed with GPG?

Yes

@rallytime rallytime left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@rallytime

rallytime commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

Comment thread salt/modules/lxd.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An URL to a remote server. The 'cert' and 'key' fields must also be provided if 'remote_addr' is defined.

Comment thread salt/modules/lxd.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what Wherever to verify the cert... means in this context. Could we make this more clear, please?

@rallytime rallytime merged commit e7bb90f into saltstack:fluorine Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants