Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lxd tests #49032

Merged
merged 4 commits into from Aug 13, 2018
Merged

add lxd tests #49032

merged 4 commits into from Aug 13, 2018

Conversation

@gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented Aug 9, 2018

What does this PR do?

Add tests for LXD

What issues does this PR fix or reference?

Closes #46846

Tests written?

Yes

Commits signed with GPG?

Yes

Copy link
Contributor

@rallytime rallytime left a comment

Very nice.

@rallytime
Copy link
Contributor

@rallytime rallytime commented Aug 10, 2018

remote_addr :
An URL to a remote Server, you also have to give cert and key if
you provide remote_addr and its a TCP Address!

This comment has been minimized.

@cachedout

cachedout Aug 10, 2018
Contributor

An URL to a remote server. The 'cert' and 'key' fields must also be provided if 'remote_addr' is defined.

~/.config/lxc/client.key
verify_cert : True
Wherever to verify the cert, this is by default True

This comment has been minimized.

@cachedout

cachedout Aug 10, 2018
Contributor

I don't know what Wherever to verify the cert... means in this context. Could we make this more clear, please?

@gtmanfred gtmanfred force-pushed the gtmanfred:fluorine branch from 8c27585 to cd9d88e Aug 10, 2018
@rallytime rallytime merged commit e7bb90f into saltstack:fluorine Aug 13, 2018
6 of 8 checks passed
6 of 8 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
@wip
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants