add lxd tests #49032
Merged
add lxd tests #49032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtmanfred Can you fix those documentation errors? Then we can get this in. |
cachedout
reviewed
Aug 10, 2018
salt/modules/lxd.py
Outdated
|
|
||
| remote_addr : | ||
| An URL to a remote Server, you also have to give cert and key if | ||
| you provide remote_addr and its a TCP Address! |
There was a problem hiding this comment.
An URL to a remote server. The 'cert' and 'key' fields must also be provided if 'remote_addr' is defined.
salt/modules/lxd.py
Outdated
| ~/.config/lxc/client.key | ||
|
|
||
| verify_cert : True | ||
| Wherever to verify the cert, this is by default True |
There was a problem hiding this comment.
I don't know what Wherever to verify the cert... means in this context. Could we make this more clear, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add tests for LXD
What issues does this PR fix or reference?
Closes #46846
Tests written?
Yes
Commits signed with GPG?
Yes