New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes flaky test and unicode environment key/value #49192

Merged
merged 1 commit into from Aug 19, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented Aug 19, 2018

What does this PR do?

  • Fix tearDown method to remove unicode environment key.
  • Mark flaky test as such, test_set_system_time fails when run at
    certian times of the day.

Tests written?

No - Fixing existing tests

Commits signed with GPG?

Yes

Test fixes
- Fix tearDown method to remove unicode environment key.
- Mark flaky test as such, test_set_system_time fails when run at
  certian times of the day.

@dwoz dwoz requested a review from gtmanfred Aug 19, 2018

@dwoz dwoz merged commit aaa9e37 into saltstack:2018.3 Aug 19, 2018

7 of 8 checks passed

jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@dwoz dwoz deleted the dwoz:git_test_fix_ng branch Aug 21, 2018

rallytime added a commit that referenced this pull request Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment