Connect before processing presence #49900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire_event's timeout is in milliseconds. Under the hood it calls connect_pull with a seconds timeout. Just call connect_pull directly before processing presense events.
ghost
self-requested a review
rallytime
approved these changes
Oct 5, 2018
isbm
approved these changes
Oct 5, 2018
skizunov
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fire_event's timeout is in milliseconds. Under the hood it calls
connect_pull with a seconds timeout. Just call connect_pull directly
before processing presense events.
Tests written?
No
Commits signed with GPG?
Yes