Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect before processing presence #49900

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@dwoz
Copy link
Contributor

commented Oct 4, 2018

fire_event's timeout is in milliseconds. Under the hood it calls
connect_pull with a seconds timeout. Just call connect_pull directly
before processing presense events.

Tests written?

No

Commits signed with GPG?

Yes

Connect before processing presence
fire_event's timeout is in milliseconds. Under the hood it calls
connect_pull with a seconds timeout. Just call connect_pull directly
before processing presense events.

@dwoz dwoz requested a review from skizunov Oct 4, 2018

@dwoz dwoz requested a review from saltstack/team-core as a code owner Oct 4, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Oct 4, 2018

@isbm

isbm approved these changes Oct 5, 2018

@rallytime rallytime merged commit cf1df79 into saltstack:2017.7 Oct 5, 2018

7 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.