Bugfix: OS arch fall-back when no RPM installed on inird image #50523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
meaksh
approved these changes
Nov 15, 2018
|
Package is out here. |
|
@isbm There are some lint errors here, it seems |
isbm
force-pushed
the
isbm-inird-no-rpm-platform-fix
branch
2 times, most recently
from
073447d
to
fd5db89
Compare
terminalmage
approved these changes
Nov 19, 2018
|
@cachedout As of lint, seems it is not related to this PR: |
added 10 commits
November 20, 2018 10:22
isbm
force-pushed
the
isbm-inird-no-rpm-platform-fix
branch
from
4260d18
to
f8deae2
Compare
|
@cachedout OK, lint error gone after rebase on |
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Nov 13, 2019
[master] Porting #50523 to master
garethgreenaway
moved this from PR needs port to master
to PR merged
in PRs to port to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bugfix.
What issues does this PR fix or reference?
Salt is unable to determine OS architecture grain on
initrdLinux images for RPM systems.Previous Behavior
OS architecture is not detected.
New Behavior
OS architecture is detected.
Tests written?
Yes