Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ci/lint fix CHANGE_BRANCH name #50909

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@damon-atkins
Copy link
Member

commented Dec 19, 2018

What does this PR do?

Fix detecting when to do the full lint

What issues does this PR fix or reference?

change params.CHANGE_BRANCH to env.CHANGE_BRANCH

Previous Behavior

Full lint test was not working.

New Behavior

Full lint test working

@damon-atkins damon-atkins requested a review from saltstack/team-core as a code owner Dec 19, 2018

@damon-atkins damon-atkins referenced this pull request Dec 19, 2018

Closed

[DO NOT MERGE] #50900

@cachedout cachedout requested a review from dubb-b Dec 19, 2018

@dubb-b

dubb-b approved these changes Dec 19, 2018

@s0undt3ch s0undt3ch merged commit 07fca64 into saltstack:2017.7 Dec 20, 2018

9 of 10 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@damon-atkins damon-atkins deleted the damon-atkins:jenkins_pylint branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.