New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick test fixes from fluorine #50917

Merged

dwoz merged 3 commits into saltstack:2018.3 from dwoz:test_fixes

Dec 19, 2018

Contributor

dwoz commented Dec 19, 2018

What does this PR do?

Backport a few Windows test suite fixes from fluorine.

Increase ShellCase timeouts.
Fix gitfs tests that broke due to unicode being passed to subprocess in the environment.

dwoz added 3 commits

December 19, 2018 10:01


          Do not pass unicode in environment

a5c8c18


          Increase and standardize ShellCase timeouts

b22f827


          Fix linter warnings

16d10fb

dwoz requested a review from twangboy

December 19, 2018 17:06

twangboy approved these changes

View reviewed changes

dwoz merged commit b08b7e1 into saltstack:2018.3

DmitryKuzmenko mentioned this pull request

gitfs works but print traceback (Windows only) #54398

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment