Use gpg's --batch in apt-key adv during repo key add #50972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes
salt.modules.aptpkg
to use GPG's--batch
flag forapt-key adv
commands.What issues does this PR fix or reference?
#50634 - GPG is attempting to write to a TTY, but can't do so in Salt's session.
--batch
puts GPG in a mode that is more suitable for unattended operation / automation.Previous Behavior
New Behavior
Tests written?
No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
It looks like this could be fixed in Debian soon-ish, but maybe it is worth it for Salt to use
--batch
for GPG commands to ensure regressions don't cause issues here?