Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid assignment in vsphere module #51146

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@terminalmage
Copy link
Contributor

commented Jan 11, 2019

Tuples are immutable, so if we reach this code it will raise a TypeError.

Fix invalid assignment in vsphere module
Tuples are immutable, so if we reach this code it will raise a
TypeError.
@dwoz

dwoz approved these changes Jan 12, 2019

@dwoz dwoz merged commit 5e37326 into saltstack:2018.3 Jan 12, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:fix-vsphere-tuple-issue branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.