Fix ssh on Windows (2018.3.4) #51544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Windows Server 2019 now includes OpenSSH by default. The tests now run on Windows Server 2019 because it's finding the ssh binary. The ssh module was gated for Windows.
This PR changes the gate to ssh binary presence and allows the ssh module to load on Windows if the binary is present. There are a few calls to
os.geteuidwhich does not exist on Windows either, so these are gated.What issues does this PR fix or reference?
https://jenkinsci.saltstack.com/job/2018.3.4/job/salt-windows-2019-py2/1/
Tests written?
Yes
Commits signed with GPG?
Yes