Remove nulls to prevent Zabbix API errors #51915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IP or DNS are null, Zabbix API returns an error. Prefer empty string over null.
twangboy
requested changes
Feb 28, 2019
Change to use default value in case of null, as per request
twangboy
approved these changes
Mar 1, 2019
dwoz
approved these changes
Mar 1, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Dec 14, 2019
[master] Porting #51915 to master
garethgreenaway
moved this from PR needs port to master
to PR merged
in PRs to port to master
garethgreenaway
moved this from PR merged
to PR has port to master
in PRs to port to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IP or DNS are null, Zabbix API returns an error. Prefer empty string over null.
What does this PR do?
Replaces nulls with empty strings in "ip" and "dns" params
What issues does this PR fix or reference?
N/A
Previous Behavior
Null ip or dns params if empty
New Behavior
Empty string ip or dns params if empty
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.