Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing client_args in influxdb module #52043

Merged
merged 2 commits into from Apr 12, 2019

Conversation

@arsiesys
Copy link

commented Mar 7, 2019

What does this PR do?

Fix #52041

See GitHub's page on GPG signing for more information about signing commits with GPG.

Loïc Yavercovski and others added 2 commits Mar 7, 2019
@dwoz dwoz added the 2019.2.1 label Apr 12, 2019
@dwoz
dwoz approved these changes Apr 12, 2019
@dwoz
dwoz approved these changes Apr 12, 2019
Copy link
Contributor

left a comment

@arsiesys Ideally we'd add a regression test for this. So any test that would cause the exception in the bug report. We are starting to tighten up the rules on testing a bit to prevent bugs from regressing. Please keep this in mind as we might require a test in the future.

@dwoz dwoz merged commit 2d59705 into saltstack:2019.2 Apr 12, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.