Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused salt.crypt import #52423

Merged
merged 4 commits into from Apr 11, 2019

Conversation

@bbinet
Copy link
Contributor

commented Apr 5, 2019

What does this PR do?

It removes unused salt.crypt import.

Previous Behavior

This causes pepper to fail on windows because of missing libcrypto.

New Behavior

Pepper does not fail anymore

Tests written?

No

Commits signed with GPG?

No

See also #51655 for similar salt.crypt removals

bbinet added 2 commits Apr 5, 2019
This causes pepper to fail on windows because of missing libcrypto.

See also #51655 for similar salt.crypt removals
@bbinet bbinet requested a review from saltstack/team-core as a code owner Apr 5, 2019
twangboy and others added 2 commits Apr 8, 2019
@dwoz dwoz merged commit b0d3c76 into saltstack:2019.2 Apr 11, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@bbinet bbinet deleted the bbinet:unused-salt-crypt branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.