Ignore retcode when checking FS type #52589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in part to check if the block device being checked actually exists. In these cases, a nonzero exit code is not an error condition, and thus should not have its results logged at the ERROR loglevel.
dwoz
reviewed
Apr 18, 2019
There was a problem hiding this comment.
@terminalmage This seems like it might be a difficult one to test, but can you think of a way to add a regression test for this bugfix?
|
@dwoz How about that? |
|
@terminalmage Looks like you got some lint |
s0undt3ch
approved these changes
Apr 19, 2019
dwoz
approved these changes
Apr 19, 2019
|
The docs will pass after #52622 is merged. |
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 18, 2019
garethgreenaway
moved this from PR needs port to master
to PR has port to master
in PRs to port to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used in part to check if the block device being checked actually exists. In these cases, a nonzero exit code is not an error condition, and thus should not have its results logged at the ERROR loglevel.