Fix slot parsing in unless/onlyif function arguments

[max-arnold]

What does this PR do?

I'm trying to improve #51846 (a feature that allows using execution modules in unless/onlyif). I want to be able to do this:

install apache on debian based distros:
  cmd.run:
    - name: make install
    - cwd: /path/to/dir/whatever-2.1.5/
    - unless:
      - fun: file.file_exists
        path: __slot__:salt:test.echo(/usr/local/bin/whatever)

Previous Behavior

Using slots as unless/onlyif function arguments doesn't work.

New Behavior

The basic expectation is that slots should work anywhere within a state.

Tests written?

WIP

Commits signed with GPG?

No

[max-arnold]

@DmitryKuzmenko I made a few changes, could you please review this again? Also it would be nice if someone independently verified that my fix works.

My initial one-line patch didn't work because the cdata dictionary does not contain unless/onlyif arguments.

team agreed with me, but we shouldn't move anything existing. We should just add the slot eval to also happen before the unless/onlyif call.

I rewrote the fix as suggested in the Slack room and added a couple of unit tests.

[max-arnold]

I would also like this to get merged before the Neon feature freeze

[Ch3LL]

FYI I migrated this PR from develop to neon to ensure it is included in the upcoming neon release. Let me know if this caused any issues. Thanks

[Ch3LL]

I noticed the test_state tests are not running, since develop runs partial tests related to the PR but it did not catch this one. I'm going to try to run a full test run so we can see the results of test_state

[Ch3LL]

re-run full all

[DmitryKuzmenko]

re-run full all

[max-arnold]

Rebased and added a release note.

[DmitryKuzmenko]

@max-arnold thank you for your work. Currently we're working on the upstream tests fixes. After that we'll have to rebase this again and ensure tests are green here. It's just a formal procedure. Sorry for delay.

[dwoz]

@max-arnold can this be re-based against master?

[max-arnold]

@dwoz Not yet. I'm waiting till #54992 is merged and also trying to make Windows test pass here: #55674

I'll ping you when the PR is ready (hopefully in a day or two)

[max-arnold]

@dwoz I fixed all the tests and ready to rebase this PR as soon as #54992 is merged

[max-arnold]

re-run full centos6-py2
re-run full centos7-py2
re-run full centos7-py2-tcp

[max-arnold]

re-run full amazon1-py2
re-run full centos6-py2
re-run full ubuntu1604-py2-tcp

[max-arnold]

@dwoz Rebased, all tests are green!