Add checks for Amazon Linux to ip module #53318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3LL
approved these changes
May 30, 2019
waynew
force-pushed
the
53171-fix-network-managed
branch
from
91ed232
to
214c5a8
Compare
|
re-run all |
|
I think somehow the tests got broken on this, just going to open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds checks for Amazon Linux to the IP module. Right now it tries to say that it's RedHat 1 or RedHat 2.
What issues does this PR fix or reference?
Fixes #53171
Previous Behavior
On Amazon Linux 1 and 2 it's treated as RedHat 1 and 2.
New Behavior
On Amazon Linux 1 it's RedHat 6, and Amazon Linux 2 is RedHat 7
Tests written?
Fixes existing test
Commits signed with GPG?
Yes