Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust beacon state test #53466

Merged
merged 5 commits into from Jun 27, 2019
Merged

More robust beacon state test #53466

merged 5 commits into from Jun 27, 2019

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jun 12, 2019 •
edited

What does this PR do?

  • Makes integration.states.test_beacon.BeaconStateTestCase.test_present_absent more robust
  • Adds amazon 2 PR builds

Issues #52245, #52926

Tests written?

No - Fixing existing test failures

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from a team as a code owner June 12, 2019 23:49
@dwoz dwoz added the v2019.2.1 unsupported version label Jun 12, 2019
@garethgreenaway garethgreenaway requested a review from a team June 13, 2019 00:29
@bryceml bryceml self-requested a review June 14, 2019 16:02
@dwoz
Copy link
Contributor Author

dwoz commented Jun 14, 2019

This may not be needed if #53493 resolves the beacon test failure

@dwoz
Copy link
Contributor Author

dwoz commented Jun 19, 2019

re-run full all

@dwoz
Copy link
Contributor Author

dwoz commented Jun 20, 2019

re-run full amazon

@dwoz dwoz force-pushed the test_pres_abs branch 6 times, most recently from efd6976 to fcb555c Compare June 27, 2019 07:59
s0undt3ch
s0undt3ch requested changes Jun 27, 2019
View reviewed changes
Copy link
Member

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please base the new pipelines with the latest of 2019.2.1 for the other linux platforms

@dwoz dwoz merged commit 75175bb into saltstack:2019.2.1 Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy requested changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@bryceml bryceml bryceml approved these changes

Assignees
No one assigned
Labels
Reviewers-Assigned v2019.2.1 unsupported version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dwoz @s0undt3ch @garethgreenaway @twangboy @bryceml @Ch3LL