Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmd.run on MacOS (rebased) #54136

Merged
merged 4 commits into from Aug 8, 2019
Merged

Fix cmd.run on MacOS (rebased) #54136

merged 4 commits into from Aug 8, 2019

Commits on Aug 7, 2019

  1. Fix environment in cmd.run runas on MacOS

    @ScoreUnder
    ScoreUnder committed Aug 7, 2019
    Copy the full SHA
    ab8b39c View commit details
    Browse the repository at this point in the history

  2. Add integration tests for cwd/runas changes on MacOS 

    Also fix a unit test that was testing for broken behaviour.
    @ScoreUnder
    ScoreUnder committed Aug 7, 2019
    Copy the full SHA
    da38993 View commit details
    Browse the repository at this point in the history

  3. Fixes to ITs 

    - ensure runas user is created when used
- mark runas tests destructive due to user creation/deletion
- fix tmpdir permission issue when cd'ing as runas user
    @ScoreUnder
    ScoreUnder committed Aug 7, 2019
    Copy the full SHA
    733d2e7 View commit details
    Browse the repository at this point in the history

  4. Add integration test justifying strange use of braces after cd in cmd… 

    ….run
    @ScoreUnder
    ScoreUnder committed Aug 7, 2019
    Copy the full SHA
    1182eb9 View commit details
    Browse the repository at this point in the history